@Itx-Psycho0: The label(s) kind/bug cannot be applied, because the repository doesn't have them.

The committers listed above are authorized under a signed CLA.

• ✅ login: Itx-Psycho0 / name: Anurag Singh (4926e6d)

Welcome @Itx-Psycho0! It looks like this is your first PR to knative-extensions/educational-game 🎉

Hi @ankitajana21 @prajjwalyd,

I have signed the CLA and verified the fix locally. The double-click crash issue is resolved.

Summary of Changes:

Added safety check for conveyerInd array bounds.

Verified with the attached video proof.

Ready for your review!

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Itx-Psycho0, prajjwalyd
Once this PR has been reviewed and has the lgtm label, please assign cali0707 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

One small concern, though:
do we need to handle the case where a player clicks the same sink more than once in levels with multiple sinks cc @ankitajana21?

@prajjwalyd I'll review this PR by today, the script is common to all levels, so I have to check it.

@Itx-Psycho0 This is not working for multi sink level, let's say I click once on blue, and twice on red, and after that I can't click on green, as it is considering 2 belts for red and not allowing the 3rd one for green. FYI, In the multi sink level, the player need not click all the sinks, the player can click less as well. The events are duplicated accordingly for the number of sinks connected.

/lgtm cancel

Hi @ankitajana21,

Thank you for the detailed feedback! You were absolutely right - my initial fix limited MultiSink to 3 connections. I've now implemented a comprehensive solution that fixes both the crash AND allows unlimited connections.

Root Cause

After debugging, I found TWO bugs:

1. Original bug: Index out of bounds on double-click (Issue [Bug] Game crashes with "Invalid access to index" on double-clicking the Sink #55)
2. Hidden bug: Scene transition order in level.gd was clearing the events array AFTER boxes added themselves, causing MultiSink to fail when playing through the full game (though it worked when running directly with F6)

Solution

ConveyerController.gd - Smart Conveyor Management

if conveyerInd >= conveyer.size():
    // Detect scene by conveyor count
    if conveyer.size() >= 3:
        // MultiSink: Create new conveyors dynamically
        var new_conveyor = conveyer[0].duplicate()
        get_tree().current_scene.add_child(new_conveyor)
        conveyer.append(new_conveyor)
    else:
        // BasicEventFlow: Stop to prevent crash
        return

level.gd - Fixed Scene Transition

// Initialize BEFORE changing scene (not after)
ConveyerController.initialise()
get_tree().change_scene_to_file(next_level_path)

Testing Results

BasicEventFlow: Double-click no longer crashes
BoxClick: Works correctly
MultiSink - Your test case: Blue once + Red twice + Green once = SUCCESS
MultiSink - Unlimited: Can now make 5+ connections
Full playthrough: All levels work in sequence

Video Demonstration

The fix now properly addresses both the crash prevention AND allows the flexible multi-sink behavior you described. Ready for review!